Automatically build TypeDoc and Storybook in CI #2450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardolsson
approved these changes
Dec 28, 2024
There was a problem hiding this comment.
Cool! I reconfigured the deployment and the latest automatic preview build is now live here:
- App: https://app-zetkin-lqr2vxva3-zetkin.vercel.app/
- Docs: https://app-zetkin-lqr2vxva3-zetkin.vercel.app/docs
- Storybook: https://app-zetkin-lqr2vxva3-zetkin.vercel.app/storybook
Since this is using a new script, this will not affect the production build, which will not expose docs or storybook.
Nice work! Let's get this merged. 💯 🟢 🟢 🟢
This was referenced Dec 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #2092. I've added the
docs:buildpackage script almost as described in your suggestion (corrected the output directory flag a little bit). Both looking good after running that command. The redirects are working great too. These screenshots are after runningyarn docs:build,yarn build, and finallyyarn start.This only deviates from your suggested diff in one other way that I'm aware of, which is that I also cut the
build-storybookpackage script. I ditched it cos I don't think it's being used and because it outputs its build into a different directory. Reckon if we end up with use cases for individual package scripts for these later down the line, maybe we want to think about having something likedocs:build-all,docs:build-storybooketc, and have the "all" build call the individual ones. But until then, maybe it's best to just cut the bloat?